Skip to content

test: disabled win-x64 test on win-arm64 too#4464

Merged
Flash0ver merged 1 commit intomainfrom
test/skip-flaky-test
Aug 25, 2025
Merged

test: disabled win-x64 test on win-arm64 too#4464
Flash0ver merged 1 commit intomainfrom
test/skip-flaky-test

Conversation

@Flash0ver
Copy link
Copy Markdown
Member

@Flash0ver Flash0ver commented Aug 22, 2025

Follow-up to

I noticed a flaky test, recently disabled on win-x64, to now flake on win-arm64 too.

Since these two are all of our Windows targets,
I propose to Skip the test for all win platforms.


Screenshot (I tried to scroll the bar twice already 😉)
image
Screenshot (I tried to scroll the bar twice already 😉)


Failing build/test:
https://github.com/getsentry/sentry-dotnet/actions/runs/17154733726/job/48668953528

Assert.Null() Failure: Value is not null
Expected: null
Actual:   SamplingTransactionProfiler { OnFinish = Action { Method = Void <Start>b__11_0(), Target = SamplingTransactionProfilerFactory { ··· } } }
   at Sentry.Profiling.Tests.SamplingTransactionProfilerTests.Profiler_WithZeroStartupTimeout_CapturesAfterStartingAsynchronously() in C:\a\sentry-dotnet\sentry-dotnet\test\Sentry.Profiling.Tests\SamplingTransactionProfilerTests.cs:line 128
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)

#skip-changelog

@jamescrosswell
Copy link
Copy Markdown
Collaborator

I propose to Skip the test for all win platforms.

👍🏻

@jamescrosswell jamescrosswell marked this pull request as ready for review August 25, 2025 00:53
@jamescrosswell jamescrosswell self-requested a review as a code owner August 25, 2025 00:53
@Flash0ver Flash0ver merged commit fe3a33b into main Aug 25, 2025
35 checks passed
@Flash0ver Flash0ver deleted the test/skip-flaky-test branch August 25, 2025 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants